Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about missing Cargo.toml keys are scarier than need be #393

Closed
fitzgen opened this issue Oct 4, 2018 · 1 comment · Fixed by #394
Closed

Warnings about missing Cargo.toml keys are scarier than need be #393

fitzgen opened this issue Oct 4, 2018 · 1 comment · Fixed by #394
Labels
feature request PR attached there's a PR open for this issue question Further information is requested
Milestone

Comments

@fitzgen
Copy link
Member

fitzgen commented Oct 4, 2018

When watching a stream of someone going through our tutorial, they got surprised/flustered/worried by these warning, so I think we can tone it down a bit somehow.

Perhaps this can just be "info" instead of all-caps and all-bold WARN? Perhaps we can collapse all the missing keys warnings into a single warning instead of multiple?

@ashleygwilliams ashleygwilliams added question Further information is requested feature request labels Oct 4, 2018
@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Oct 4, 2018
@ashleygwilliams ashleygwilliams added the help wanted Extra attention is needed label Oct 4, 2018
@mstallmo
Copy link
Member

mstallmo commented Oct 5, 2018

I can get working on this if no one else has already claimed it!

@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed help wanted Extra attention is needed labels Oct 5, 2018
@ashleygwilliams ashleygwilliams modified the milestones: 0.6.0, 0.5.1 Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request PR attached there's a PR open for this issue question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants