Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong dependency flagged as missing #377

Closed
yoshuawuyts opened this issue Sep 26, 2018 · 1 comment
Closed

wrong dependency flagged as missing #377

yoshuawuyts opened this issue Sep 26, 2018 · 1 comment
Labels
bug Something isn't working PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Milestone

Comments

@yoshuawuyts
Copy link
Contributor

🐛 Bug description

I ran wasm-pack test without wasm-bindgen-test installed, and got a message about wasm-bindgen not being installed instead.

🤔 Expected Behavior

I should have received a warning about wasm-bindgen-test not being installed. Instead I had to read through the detailed log below to figure out what was wrong, which is easier to miss.

👟 Steps to reproduce

Given the following Cargo.toml

[package]
name = "my_crate"
version = "0.1.0"

[lib]
crate-type = ["cdylib"]

[dependencies]
failure = "0.1.2"
wasm-bindgen = "0.2.23"

[dependencies.web-sys]
version = "0.3.0"
features = [
  "Document",
  "EventTarget",
]

run

$ wasm-pack test

It will complain about wasm-bindgen not existing, but the result will show that wasm-bindgen-test is missing.

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: 0.5.0
rustc version: 1.30-nightly

Screenshot

2018-09-26-213952_1920x1080

fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 26, 2018
@ashleygwilliams ashleygwilliams added bug Something isn't working to-do stuff that needs to happen, so plz do it k thx labels Sep 26, 2018
@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Sep 26, 2018
@ashleygwilliams
Copy link
Member

ack! thanks for the detailed issue! this is indeed a bug and we should fix it! looks like @fitzgen already has a PR ;)

@ashleygwilliams ashleygwilliams added the PR attached there's a PR open for this issue label Sep 26, 2018
ashleygwilliams pushed a commit that referenced this issue Oct 1, 2018
@ashleygwilliams ashleygwilliams modified the milestones: 0.6.0, 0.5.1 Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Development

No branches or pull requests

2 participants