Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show all install options on load, show detected system recommendation first #355

Closed
ashleygwilliams opened this issue Sep 24, 2018 · 0 comments · Fixed by #1242
Closed

show all install options on load, show detected system recommendation first #355

ashleygwilliams opened this issue Sep 24, 2018 · 0 comments · Fixed by #1242
Labels
help wanted Extra attention is needed PR welcome

Comments

@ashleygwilliams
Copy link
Member

it's.. just a little weird right now. i'm thinking we should just always display all the options but give the primary one first. we should also update the text to say if you "hate curl installer" to just use cargo or download the binary from github.
@ashleygwilliams ashleygwilliams added enhancement New feature or request to-do stuff that needs to happen, so plz do it k thx labels Sep 24, 2018
@ashleygwilliams ashleygwilliams added this to the 0.5.0 milestone Sep 24, 2018
@ashleygwilliams ashleygwilliams self-assigned this Sep 24, 2018
@ashleygwilliams ashleygwilliams modified the milestones: 0.5.0, 0.6.0 Oct 1, 2018
@ashleygwilliams ashleygwilliams modified the milestones: 0.6.0, 0.7.0 Dec 27, 2018
@ashleygwilliams ashleygwilliams added the current release current todo items label Mar 14, 2019
@ashleygwilliams ashleygwilliams removed their assignment Mar 14, 2019
@ashleygwilliams ashleygwilliams modified the milestones: 0.8.0, 0.9.0 Mar 24, 2019
@ashleygwilliams ashleygwilliams removed this from the 0.9.0 milestone May 16, 2019
@ashleygwilliams ashleygwilliams removed the current release current todo items label May 16, 2019
@ashleygwilliams ashleygwilliams changed the title cleanup install exp JS show all install options on load, show detected system recommendation first Jul 16, 2019
@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed and removed enhancement New feature or request to-do stuff that needs to happen, so plz do it k thx labels Jul 16, 2019
@ashleygwilliams ashleygwilliams mentioned this issue Feb 8, 2020
Closed
oyamauchi added a commit to oyamauchi/wasm-pack that referenced this issue Mar 16, 2023
@oyamauchi
Don't hide install options behind link
50e9410 
- First, show only the instructions specific to the detected platform.

- Then, always display the cargo, npm, and yarn install options below.

- Add a note to the unix instructions to say you can use the
  alternative options if you don't like piping `curl` into `sh`.

Fixes rustwasm#355
@oyamauchi oyamauchi mentioned this issue Mar 16, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed PR welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't hide install options behind link oyamauchi/wasm-pack
1 participant
@ashleygwilliams