Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a wasm-pack test command #248

Closed
2 of 3 tasks
fitzgen opened this issue Aug 2, 2018 · 0 comments · Fixed by #306
Closed
2 of 3 tasks

Add a wasm-pack test command #248

fitzgen opened this issue Aug 2, 2018 · 0 comments · Fixed by #306
Assignees
@fitzgen
Labels
question Further information is requested to-do stuff that needs to happen, so plz do it k thx
Milestone
0.5.0

Comments

@fitzgen
Copy link
Member

fitzgen commented Aug 2, 2018 •
edited
Loading

This still needs some design work before we start any PRs!

Open questions:

  • How to best determine whether a project is using wasm-pack-test? Probably reading Cargo.toml dev dependencies?

  • How to best determine whether a project has JS integration tests? Inspect whatever mechanism we settle on for including random stuff into the pkg directory / merging things into package.json?

  • Does this run native cargo #[test]s too?

  • Does this command install geckodriver / chromedriver for you if needed?
@fitzgen fitzgen added this to the 0.6.0 milestone Aug 2, 2018
@fitzgen fitzgen mentioned this issue Aug 2, 2018
Closed
@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed question Further information is requested to-do stuff that needs to happen, so plz do it k thx labels Aug 7, 2018
@fitzgen fitzgen self-assigned this Aug 24, 2018
@fitzgen fitzgen removed the help wanted Extra attention is needed label Aug 24, 2018
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Aug 28, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
a6ad544 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Aug 31, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
6660d0f 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 4, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
c4bc8f0 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
031d70e 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
f710b7e 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
2b2d6b9 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
7528da3 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
ffbff90 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
238781c 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
a4013f4 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
6ec0d1a 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
57a4cfd 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
db86bb5 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate. It will run tests in both node and browsers using
WebDriver clients.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 5, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
041438e 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate. It will run tests in both node and browsers using
WebDriver clients.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 7, 2018
@fitzgen
feature: Implement a wasm-pack test subcommand
8f40e5d 
This is a wrapper over `cargo test --target wasm32-unknown-unknown` and the
`wasm-bindgen-test` crate. It will run tests in both node and browsers using
WebDriver clients.

Fixes rustwasm#248
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Sep 13, 2018
@fitzgen
feature(test): Add a wasm-pack test subcommand
577d1b3 
This uses `wasm-bindgen-test` under the hood.

Fixes rustwasm#248
@fitzgen fitzgen mentioned this issue Sep 13, 2018
Merged
3 tasks
ashleygwilliams pushed a commit that referenced this issue Oct 1, 2018
@fitzgen @ashleygwilliams
feature(test): Add a wasm-pack test subcommand
c8aac65 
This uses `wasm-bindgen-test` under the hood.

Fixes #248
@ashleygwilliams ashleygwilliams modified the milestones: 0.6.0, 0.5.0 Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fitzgen fitzgen

Labels
question Further information is requested to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

feature(test): Add a wasm-pack test subcommand fitzgen/wasm-pack
2 participants
@fitzgen @ashleygwilliams