Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to parse manifest in cargo workspace when using package table's #1240

Closed
LetsMelon opened this issue Mar 12, 2023 · 2 comments
Closed

Comments

@LetsMelon
Copy link

🐛 Bug description

I'm using cargo workspaces and I have one seperate member for my wasm build.

The workspace-root-member cargo.toml:

[workspace]
# ...

[workspace.package]
version = "some version"
license = "some license"
repository = "some url"

The wasm-member cargo.toml:

[package]
# ...
version.workspace = true
license.workspace = true
repository.workspace = true
# ...

but wasm-packis unable to parse my cargo.toml and panics with the error message Caused by: invalid type: map, expected a string for key 'package.license'.

Cargo doc for package table: link

🤔 Expected Behavior

wasm-pack should be able to parse my Cargo.toml like cargo.

👟 Steps to reproduce

Create a new workspace project and add package table informations into the root Cargo.toml, then reference from a workspace member to the package table and the last step is to build the workspace member with wasm-pack.

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: 0.10.3
rustc version: rustc 1.69.0-nightly (f3126500f 2023-02-02)
cargo version: cargo 1.69.0-nightly (e84a7928d 2023-01-31)

@LetsMelon
Copy link
Author

Seems like it is the same problem as described in #1180 .

@LetsMelon
Copy link
Author

And looks like if #1185 fixes this bug, so I will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant