-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for workspace inheritance #1185
Conversation
Anything I can help to move this PR forward? |
It's blocked by #1188 |
Thanks for the update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and sounds like a better solution! Thanks a lot.
Will merge it once #1188 is merged.
Rebased onto #1188 and resolved the merge conflicts. |
will this one release a new version? like v0.11.0 🤔 |
Yes, will do that in a near future :) |
Hi there! Just would like to bump this up. How's the new release going? Anything I can help with it? can't wait to build our project with this feature 😎 |
Shares edition, description, license, repository and documentation fields ref. rustwasm/wasm-pack#1185 so this commit changes does not contain wasm-pack related workspaces
This PR adds support for reading metadata from crates using the workspace inheritance feature introduced in Rust 1.64.
I've implemented this by bumping the
cargo_metadata
dependency to the latest version, and using its metadata for thedescription
,license
,license-file
,repository
andhomepage
fields, instead of parsing theCargo.toml
file directly. This should also makewasm-pack
more resilient to futureCargo.toml
format changes.I've tested the change locally and it seems to work perfectly.
Fixes #1180.
Make sure these boxes are checked! 📦✅
rustfmt
installedcargo fmt
on the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨