Eliminate duplicate types in the type section #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
gc-types
branch
from
37b184f
to
16c015a
Compare
alexcrichton
force-pushed
the
master
branch
2 times, most recently
from
83a1db1
to
1fa407d
Compare
alexcrichton
force-pushed
the
gc-types
branch
2 times, most recently
from
b0a595e
to
f22c635
Compare
fitzgen
approved these changes
Oct 29, 2018
This commit updates the `wasm-gc` pass of wasm-bindgen to eliminate duplicate types in the type section, effectively enabling a gc of the type section itself. The main purpose here is ensure that code generated by `wasm-bindgen` itself doesn't have to go too far out of its way to deduplicate at generation time, but rather it can rely on the gc pass to clean up. Note that this currently depends on paritytech/parity-wasm#231, but this can be updated if that ends up not landing.
alexcrichton
force-pushed
the
gc-types
branch
from
f22c635
to
27001a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
wasm-gcpass of wasm-bindgen to eliminateduplicate types in the type section, effectively enabling a gc of the
type section itself. The main purpose here is ensure that code generated
by
wasm-bindgenitself doesn't have to go too far out of its way todeduplicate at generation time, but rather it can rely on the gc pass to
clean up.
Note that this currently depends on paritytech/parity-wasm#231, but this
can be updated if that ends up not landing.