Add overloads with endianness parameter to DataView gets and sets #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villhei
reviewed
Oct 15, 2018
crates/js-sys/src/lib.rs
Outdated
| /// The getFloat64() method gets a signed 32-bit float (float) at the specified | ||
| /// byte offset from the start of the DataView. | ||
| /// | ||
| /// [MDN documentation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView/getFloat64) | ||
| #[wasm_bindgen(method, js_name = getFloat64)] | ||
| pub fn get_float64(this: &DataView, byte_offset: usize) -> f64; | ||
|
|
||
| /// The getFloat64() method gets a signed 32-bit float (float) at the specified |
There was a problem hiding this comment.
Looks like this bit size is lost in the wrong comment
|
Looks great to me, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.