Conditionally enable bindings for wasm32-wasi with --wasi flag
#3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temeddix
changed the title
wasm32-wasi with --wasi flagwasm32-wasi with --wasi flag
temeddix
changed the title
wasm32-wasi with --wasi flagwasm32-wasi conditionally with --wasi flag
temeddix
changed the title
wasm32-wasi conditionally with --wasi flagwasm32-wasi with --wasi flag
|
Also, please make sure it makes sense to move forward with a PR before you make one with us. It feels really bad closing PRs like that, I prefer not to waste anybodies time. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3233(Jan 2023), generating bindings for WASI was disabled.
wasm32-wasi#3233However, with #3595(Sep 2023)
wasm-bindgengained compatibility withwasm32-wasi's standard C ABI. It was stated in #3454 by @Liamolucko thatwasm-bindgenalready supports the standard C ABI thatwasm32-wasiuses.wasm-bindgencompatible with the standard C ABI #3595This PR aims to enable bindings for
wasm32-wasiunder the new--wasiflag. This will allow ecosystem aroundwasm-bindgensuch aswasm-packto make use ofwasm32-wasi.I'm very open to feedback, so please tag me if there's room for improvements. I should perhaps add or modify some tests for now.