Fix build of raytrace example on nightly #2488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this will be blocked on rust-lang/stdarch#1073 to land for now. |
This was referenced Mar 11, 2021
|
Any updated on this? rust-lang/stdarch#1073 seems to have landed. Something we need to update on the wasm-bindgen side too? |
|
This is still blocked on that landing in rust-lang/rust itself. |
|
Any updates on this? AFAIK the stdarch stuff has landed a while ago to rust-lang/rust. |
|
Unfortunately stdarch has not been updated |
The `__wasm_init_memory` function is no longer exported and we also need to build with `+mutable-globals`. Closes rustwasm#2487
alexcrichton
force-pushed
the
update-raytrace
branch
from
08f7488 to
ad53c12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__wasm_init_memoryfunction is no longer exported and we also needto build with
+mutable-globals.Closes #2487