Whitelist send_with_u8_array slice #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limira
reviewed
Feb 28, 2020
crates/webidl/src/lib.rs
Outdated
| @@ -244,6 +244,8 @@ fn immutable_slice_whitelist() -> BTreeSet<&'static str> { | |||
| "clearBufferfv", | |||
| "clearBufferiv", | |||
| "clearBufferuiv", | |||
| // WebSocket | |||
| "send_with_u8_array", | |||
There was a problem hiding this comment.
I am not sure but I think it requires camelCase?
There was a problem hiding this comment.
Hm yeah it looks like the others are all camel-case here. @chinedufn mind testing this out locally to see if it had the desired effect on the method?
There was a problem hiding this comment.
chinedufn
commented
Feb 28, 2020
| // TODO: Add a function to create another type to test here. | ||
| // These functions come from element.js | ||
| } | ||
|
|
||
| // TODO: Uncomment WebGlRenderingContext test. Every now and then we can check if this works |
There was a problem hiding this comment.
Checking to see if these tests can pass in CI now sine it's been a year
chinedufn
force-pushed
the
ws-whitelist
branch
from
fb470be
to
1097daa
Compare
chinedufn
force-pushed
the
ws-whitelist
branch
from
1097daa
to
638bd6f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2014