Fix anyref table export in empty modules #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue previously introduced around handling the anyref table, gracefully handling the case where the source module doesn't actually use the anyref table at all, meaning that the logic around initializing it can be entirely skipped.
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this pull request
Aug 12, 2019
Turns out rustwasm#1704 was buggy and ended up never injecting initialization because the anyref table was never present! This fixes that issue and this should now be tested on CI to ensure this doesn't regress and future changes preserve correctness
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this pull request
Aug 12, 2019
Turns out rustwasm#1704 was buggy and ended up never injecting initialization because the anyref table was never present! This fixes that issue and this should now be tested on CI to ensure this doesn't regress and future changes preserve correctness
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this pull request
Aug 12, 2019
Turns out rustwasm#1704 was buggy and ended up never injecting initialization because the anyref table was never present! This fixes that issue and this should now be tested on CI to ensure this doesn't regress and future changes preserve correctness
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this pull request
Aug 13, 2019
Turns out rustwasm#1704 was buggy and ended up never injecting initialization because the anyref table was never present! This fixes that issue and this should now be tested on CI to ensure this doesn't regress and future changes preserve correctness
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this pull request
Aug 13, 2019
Turns out rustwasm#1704 was buggy and ended up never injecting initialization because the anyref table was never present! This fixes that issue and this should now be tested on CI to ensure this doesn't regress and future changes preserve correctness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue previously introduced around handling the
anyref table, gracefully handling the case where the source module
doesn't actually use the anyref table at all, meaning that the logic
around initializing it can be entirely skipped.