Add doc comments export for typescript #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heh that looks like it wasn't so hard after all! Unfortunately we don't have a ton of tests for the TypeScript output right, now, but I'm curious if you've had a chance to test this out locally to make sure comments go to the right location? |
|
Yep I did! They go in the |
|
Nice! Sounds good to me then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exporting Rust doc comments to TypeScript defs.
This is just pushing the comment string to the
typescriptvariable onContextright after pushing it toglobalsfor JS.I'm not sure if there are any significant differences between JS Doc and TypeScript docs, so I didn't add in any additional formatting. I'd be happy to try and add that if there are any.
This is my first code contribution, so please let me know if there are additional things needed for this PR.
Thanks!
Fixes #1276