Inheritance & Generics #4087
-
SummaryHello, i'm creating a game engine and I'm trying to implement collisions. I need to implement it for all Additional Detailsexport class Graphic { ... }
export class Rectangle extends Graphic { ... }
...#[wasm_bindgen]
extern "C" {
pub type Graphic;
pub type Circle;
pub type Ellipse;
pub type Line;
pub type Rectangle;
}So firstly i would have to know what kind of instance it is so here is just a function to do that. Unfortunately it doesn't work: the output is always "???" #[wasm_bindgen]
pub fn show_info(graphic: &Graphic) {
if graphic.is_instance_of::<Ellipse>() {
console_log!("Ellipse");
} else if graphic.is_instance_of::<Circle>() {
console_log!("Circle");
} else if graphic.is_instance_of::<Rectangle>() {
console_log!("Rectangle");
} else if graphic.is_instance_of::<Line>() {
console_log!("Line");
} else {
console_log!("???");
}
}let testRect = new cazan.graphics.Rectangle({
game: game,
position: {x: 10, y: 10},
dimensions: {width: 50, height: 50},
styles: {
graphic: blackStyle
}
})
show_info(testRect)Thanks to you all for your help :). If you need more details i'm answering for sure |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 5 replies
-
|
I'm unfortunately unfamiliar with integrating with JS, but everything here looks right. I don't think Could you provide a complete but minimal example that reproduces your issue? |
Beta Was this translation helpful? Give feedback.
-
|
I supposed that putting "Graphic" as the type of the argument could "limit" the variable so I tried with "JsValue" but it still doesn't work. |
Beta Was this translation helpful? Give feedback.
-
|
The JS side I guess. In general, giving a complete minimal reproducible example is the way to go about those sort of issues. |
Beta Was this translation helpful? Give feedback.
-
|
We use rollup so all the js is in the same file "cazan.js"
use wasm_bindgen::prelude::*;
#[wasm_bindgen]
extern "C" {
pub type Graphic;
#[wasm_bindgen(extends = Graphic)]
pub type Circle;
#[wasm_bindgen(extends = Graphic)]
pub type Ellipse;
#[wasm_bindgen(extends = Graphic)]
pub type Line;
#[wasm_bindgen(extends = Graphic)]
pub type Rectangle;
}
#[wasm_bindgen(start)]
pub fn main() {
utils::set_panic_hook(); // Generated
}
#[wasm_bindgen]
extern "C" {
#[wasm_bindgen(js_namespace = console)]
pub fn log(s: &str);
}
#[wasm_bindgen]
pub fn show_info(graphic: &JsValue) {
if graphic.has_type::<Rectangle>() {
log("rectangle");
} else if graphic.has_type::<Graphic>() {
log("not rectangle");
} else {
log("...")
}
}
export class Graphic {}
export class Ellipse extends Graphic {}
export class Circle extends Graphic {}
export class Rectangle extends Graphic {}
export class Line extends Graphic {}
import * as cazan from "/cazan.js"
import * as wasm from "./pkg/wasm.js" // The WASM
let testRect = new cazan.Rectangle()
wasm.show_info(testRect) // "..."<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<script src="/app.js" type="module"></script>
</head>
<body>
</body>
</html>Note: pub fn get_constructor_name(obj: &JsValue) -> Option<String> {
if let Some(obj_ref) = obj.dyn_ref::<Object>() {
if let Ok(constructor) = Reflect::get(obj_ref, &"constructor".into()) {
if let Some(constructor_name) = constructor.dyn_ref::<js_sys::Function>() {
return constructor_name.name().as_string();
}
}
}
None
} |
Beta Was this translation helpful? Give feedback.
-
#[wasm_bindgen(raw_module = "./cazan.js")]
extern "C" {
pub type Graphic;
#[wasm_bindgen(extends = Graphic)]
pub type Circle;
#[wasm_bindgen(extends = Graphic)]
pub type Ellipse;
#[wasm_bindgen(extends = Graphic)]
pub type Line;
#[wasm_bindgen(extends = Graphic)]
pub type Rectangle;
}Does the trick for me. |
Beta Was this translation helpful? Give feedback.
-
|
It works! Cazan.js is in the parent directory so i used Actually i have tried with Thank you very much :) |
Beta Was this translation helpful? Give feedback.
Does the trick for me.
See the
wasm-bindgenGuide on this topic.