Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a clippy job in CI #267

Closed
wants to merge 33 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
b30aa65
upgrade wasmparser & wasm-encoder to v0.211.0
lwshang Jun 25, 2024
2df4d06
fmt
lwshang Jun 25, 2024
96a546b
cleanup workflow yml
lwshang Jun 25, 2024
2a6023c
update testsuite and skip all proposals
lwshang Jun 27, 2024
58b33f6
proc-macro has dash now
lwshang Jun 27, 2024
443462d
fix for bulk.wast by refresh elements
lwshang Jun 28, 2024
8c38eb5
bump to 0.212.0 and follow the features in wasm-tools
lwshang Jun 28, 2024
5eee359
fix elem.wast which failed in gc pass
lwshang Jun 28, 2024
60444cb
handle RefNull
lwshang Jun 29, 2024
fc4c360
always use default features from wasmparser
lwshang Jun 29, 2024
704239d
overhaul spec-tests.rs
lwshang Jun 29, 2024
26afde9
enable multi-memory spec-tests
lwshang Jun 29, 2024
98ea980
fix wabt bin path
lwshang Jun 29, 2024
9fc633f
fix binaryen bin path
lwshang Jun 29, 2024
6c0a24f
no memory64
lwshang Jun 29, 2024
f1bedde
typo
lwshang Jun 29, 2024
a098696
separate RefType
lwshang Jun 29, 2024
0f93d3c
rename InitExpr -> ConstExpr
lwshang Jun 29, 2024
4f029f0
align Memory with wasm-tools
lwshang Jun 29, 2024
2d54251
TODO for operators
lwshang Jun 29, 2024
8272e87
apply clippy fix
lwshang Jun 29, 2024
f455d79
Revert "apply clippy fix"
lwshang Jun 29, 2024
c1302d3
Reapply "apply clippy fix"
lwshang Jun 29, 2024
dac96ca
list all unimplemented operators
lwshang Jul 2, 2024
e40af5f
comment
lwshang Jul 2, 2024
a4f5965
Update src/module/mod.rs
lwshang Jul 2, 2024
bac785f
Merge branch 'upgrade_dependencies' into clippy
lwshang Jul 2, 2024
f4709ac
clippy cont.
lwshang Jul 2, 2024
17ad0da
upgrade criterion and fix deprecated
lwshang Jul 2, 2024
08d335e
upgrade env_logger
lwshang Jul 2, 2024
f51b828
add clippy CI job
lwshang Jul 2, 2024
96c5762
format main.yml
lwshang Jul 2, 2024
3763487
Merge branch 'main' into clippy
lwshang Jul 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix elem.wast which failed in gc pass
  • Loading branch information
lwshang committed Jun 28, 2024
commit 5eee359b6ee651bbdb8abc9dd2f0e49b5679fcfa
13 changes: 13 additions & 0 deletions src/passes/used.rs
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,19 @@ impl Used {
stack.push_func(*f);
});
}
if let ElementItems::Expressions(crate::ValType::Funcref, items) = &e.items {
for item in items {
match item {
InitExpr::Global(g) => {
stack.push_global(*g);
}
InitExpr::RefFunc(f) => {
stack.push_func(*f);
}
_ => {}
}
}
}
if let ElementKind::Active { offset, table } = &e.kind {
if let InitExpr::Global(g) = offset {
stack.push_global(*g);
Expand Down