Announcing the web-sys crate!
#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgattozzi
approved these changes
Sep 26, 2018
| <a style="max-width: 300px; float: right; padding: 1.5em; font-size: 80%" href="/images/new-wasm-bindgen-architecture.png"> | ||
| <img alt="wasm-bindgen's new architecture with a WebIDL frontend" | ||
| src="/images/new-wasm-bindgen-architecture.png"/> | ||
| `wasm-bindgen`'s new architecture with its WebIDL frontend. |
There was a problem hiding this comment.
You probably want a <br> tag here so that it's below the image
| exactly that. | ||
|
|
||
| <div style="clear: both"/> | ||
| <style>h2, h3 { margin-top: 15px; }</style> |
There was a problem hiding this comment.
These two lines are just being rendered as text, possibly due to div not having a closing or opening tag
There was a problem hiding this comment.
Or it just being GitHub sanitizing it
There was a problem hiding this comment.
I think it is that; when I run locally with jekyll, display is fine.
Thanks for the review! ^_^
|
|
||
| [More information and source code.](https://rustwasm.github.io/wasm-bindgen/examples/paint.html) | ||
|
|
||
| <iframe src="https://rustwasm.github.io/wasm-bindgen/exbuild/paint/" style="min-width: 662px; min-height: 502px;"></iframe> |
There was a problem hiding this comment.
Same thing as above so my guess is sanitizing by GitHub
fitzgen
force-pushed
the
announcing-web-sys
branch
from
f2447df to
0b82c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.