Added #[wasm_bindgen] for all mentions of impl Universe #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explain the motivation for making this change. What existing problem does the pull request solve? 🤔
The first mentions of
impl Universe
don't have#[wasm_bindgen]
, this results incargo build
running successfully but thewasm_game_of_life.d.ts
file containing only this type def forUniverse
:#[wasm_bindgen]
is added later, which works perfectly! But admittedly, while studying the code, I didn't read the code outside ofimpl Universe
, and had to spend time debugging and wondering why thed.ts
file is correct forgreet()
but notUniverse
.Might save the time for some other people as well; making sure the
#[wasm_bindgen]
is not missable!