crates/grep-cli: add advisory for arbitrary binary execution on Windows #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report!
To clarify, is the old function with the problematic behavior still accessible through the public API? |
|
You forgot to fill in the title |
Instead of dancing around it, we just say it: the main issue is that std::process::Command will resolve relative binary names with respect to the CWD first, because it just uses the Windows API for this. More specifically, we call out the two particular mitigations that are now in place.
|
@CodesInChaos Thanks, fixed! @Shnatsel I pushed an update. Does it answer your question? |
|
It does. Thanks! |
|
btw is there a github issue for the underlying |
|
@CodesInChaos No, but there should be. (At least, I don't think there's one.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref BurntSushi/ripgrep#1773