Add advisory for rtrb: panic-safety double-free in ReadChunk::commit - #3158
Open
tooson9010-spec wants to merge 1 commit into
Open
Add advisory for rtrb: panic-safety double-free in ReadChunk::commit#3158tooson9010-spec wants to merge 1 commit into
tooson9010-spec wants to merge 1 commit into
Conversation
Add advisory for rtrb: panic-safety double-free in ReadChunk::commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected crate(s)
rtrb(3,205,892 recent downloads per crates.io)Links to upstream issue(s) or PR(s)
Reported in mgeier/rtrb#185. Fixed in mgeier/rtrb#186, released in 0.3.5 and 0.4.0.
Severity
Panic-safety unsoundness in
ReadChunk::commit/commit_all: the committed elements are dropped before the consumer head is advanced, so a panicking elementDropleaves the head pointing at already-dropped slots. TheRingBufferdestructor then drops them again — a double free (CWE-415) / use-after-free (CWE-416) reachable from safe Rust, confirmed under AddressSanitizer. Fixed in 0.3.5 and 0.4.0.Checklist
RUSTSEC-0000-0000as the IDdatefield is set to the public disclosure date