Skip to content

Add ruzstd uninit/out-of-bounds memory reads advisory #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shnatsel merged 3 commits into from
Nov 28, 2024
Merged

Add ruzstd uninit/out-of-bounds memory reads advisory #2147

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5b92d8
Add ruzstd uninit/out-of-bounds reads advisory
paolobarbolini Nov 27, 2024
04552f4
Update description with impact analysis from the maintainer
Shnatsel Nov 28, 2024
9979aea
fix typo
Shnatsel Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions crates/ruzstd/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "ruzstd"
date = "2024-11-28"
url = "https://github.com/KillingSpark/zstd-rs/issues/75"
categories = ["memory-exposure"]
references = ["https://github.com/KillingSpark/zstd-rs/pull/76"]

[versions]
patched = [">= 0.7.3"]
unaffected = ["< 0.7.0"]
```

# `ruzstd` uninit and out-of-bounds memory reads

Affected versions of `ruzstd` miscalculate the length of the allocated
and init section of its internal `RingBuffer`, leading to uninitialized
or out-of-bounds reads in `copy_bytes_overshooting` of up to 15 bytes.

This may result in up to 15 bytes of memory contents being written
into the decoded data when decompressing a crafted archive.
This may occur multiple times per archive.