types: avoid markdown footnotes #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightly rustdoc flags these as non-standard markdown, and they don't render as nicely as just using a link.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 97.30% 97.30%
=======================================
Files 19 19
Lines 4237 4237
=======================================
Hits 4123 4123
Misses 114 114 ☔ View full report in Codecov by Sentry. |
ctz
approved these changes
Jul 6, 2024
|
Just to be clear, you got a warning because you were missing a colon. The footnote could have been fixed this way: -[^1] <https://www.rfc-editor.org/rfc/rfc5280#section-5.3.1>
+[^1]: <https://www.rfc-editor.org/rfc/rfc5280#section-5.3.1> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly rustdoc flags these as non-standard markdown, and they don't render as nicely as just using a link. See also rustls/rustls#2033
Fixes build errors on main.