-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
derive Debug for RingAlgorithm, AwsLcRsAlgorithm #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
force-pushed
the
cpu-debug-for-ring-algo
branch
from
November 28, 2023 22:53
3d25471
to
437c85a
Compare
cpu
changed the title
ring_algs: derive Debug for RingAlgorithm
derive Debug for RingAlgorithm, AwsLcRsAlgorithm
Nov 28, 2023
The `SignatureVerificationAlgorithm` in pki-types was changed to have a `Debug` bound, so these types needs to be `Debug` to implement the trait.
cpu
force-pushed
the
cpu-debug-for-ring-algo
branch
from
November 28, 2023 22:54
437c85a
to
ebd4ccc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 97.21% 97.16% -0.05%
==========================================
Files 19 19
Lines 4266 4268 +2
==========================================
Hits 4147 4147
- Misses 119 121 +2 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 28, 2023
GlenDC
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (FWIW)
djc
approved these changes
Nov 29, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SignatureVerificationAlgorithm
in pki-types was changed to have aDebug
bound (rustls/pki-types#13), so these type needs to beDebug
to implement the trait.