Conversation
ctz
approved these changes
Feb 2, 2026
djc
force-pushed
the
tweak-cli
branch
2 times, most recently
from
b3bdd4e to
6ead226
Compare
Member
Author
|
(Would like another round of review here, for test removal and further CLI tweaks.) |
ctz
approved these changes
Feb 2, 2026
Comment on lines
-117
to
+118
| .arg("revocation-check") | ||
| .arg("high") | ||
| .arg("revocation") | ||
| .arg("check") |
Member
There was a problem hiding this comment.
Theoretically this could be flattened back to revocation-check? Depends if we expect to have other things under revocation which would be siblings of check?
Member
Author
There was a problem hiding this comment.
Yeah -- given that revocation check is the same number of characters to type, I think the added modularity is a nice win even if we don't end up needing it.
I'm wondering if we should move fetch and/or verify into revocation...
This was error prone due to divergent serial handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.