Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android-release-support 0.1.1, rustls-platform-verifier 0.3.3 #114

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Jul 15, 2024

Proposed release notes

  • Fixed inclusion of relevant license files in published crates.
  • Android: revocation checking is no longer attempted for non-public certificates from private PKIs.

Post-merge steps

  • Generate Android Maven artifacts locally
  • Create and push Git tag
  • cargo publish for each required crate, based on release steps
  • Create companion GitHub release

@cpu cpu self-assigned this Jul 15, 2024
@cpu cpu changed the title Cpu release prep android-release-support 0.1.1, rustls-platform-verifier 0.3.3 Jul 15, 2024
@cpu
Copy link
Member Author

cpu commented Jul 15, 2024

Create and push Git tag

@complexspaces Do you have thoughts on how we should handle this step when both crate versions are updated? Are tags only created for rustls-platform-verifier versions, not the support crate?

@cpu
Copy link
Member Author

cpu commented Jul 19, 2024

@complexspaces Is there any chance you can take a look at this today? I'll be out of office next week. Thanks!

@complexspaces
Copy link
Collaborator

@cpu Sorry for the delay, I missed the original notification email.

I think it makes sense to only create tags for the main crate's release and simply bump it's patch version each time the Android support library changes vs trying to maintain two different version series.

@cpu
Copy link
Member Author

cpu commented Jul 20, 2024

I think it makes sense to only create tags for the main crate's release

SGTM. Do the release notes look good? Anything I need to do for a stamp?

@complexspaces
Copy link
Collaborator

Anything I need to do for a stamp?

No, this looks good. I just forgot to press approve.

@cpu cpu merged commit 669ace0 into rustls:main Jul 29, 2024
18 checks passed
@cpu cpu deleted the cpu-release-prep branch July 29, 2024 13:17
@cpu
Copy link
Member Author

cpu commented Jul 29, 2024

Run ci/package_android_release.sh in a UNIX compatible shell

Done.

(Optional) cargo publish -p rustls-platform-verifier-android --dry-run --alow-dirty

Done.

(Optional) Inspect extracted archive to ensure the local Maven repository artifacts are present
Un-tar the rustls-platform-verifier-android-*.crate file inside of target/package.
Verify maven/rustls/rustls-platform-verifier contains a single *.RELEASE directory and that contains a .aar file.
(Optional) If the releaser has an external Gradle project that uses the configuration from the README, paste the path to the unzipped package's Cargo.toml as a replacement for the manifestPath variable. Run a Gradle Sync and observe everything works.

Done (minus the last step using a dependent gradle package).

Ensure that all version changes are committed to the correct branch before proceeding. All version increases should be checked in prior to publishing on crates.io.

Done.

Publish the Android artifacts' new version: cargo publish -p rustls-platform-verifier-android --alow-dirty

Published rustls-platform-verifier-android v0.1.1 at registry crates-io

Commit main crate's version increase on the release branch

Done.

Ensure that all version changes are committed to the correct branch before proceeding. All version increases should be checked in prior to publishing on crates.io.

Done.

Publish the main crate's new version: cargo publish -p rustls-platform-verifier

Published rustls-platform-verifier v0.3.3 at registry crates-io

Follow the remaining steps in RELEASING to create the appropiate version tag.

  • [new tag] v/0.3.3 -> v/0.3.3

If a new Android component release was made: Before publishing the GitHub release, run ./ci/archive_android_release.sh to create a reproducible archive containing the Android Maven components that were just published to crates.io. After creating the archive, upload it as an additional release artifact on GitHub. Then, finish the release creation like normal.

Done: https://github.com/rustls/rustls-platform-verifier/releases/tag/v%2F0.3.3

@cpu
Copy link
Member Author

cpu commented Jul 29, 2024

@complexspaces I think I've finished this release correctly but it's the first time I've gone through the process for a release that required generating/attaching the android-artifacts.tar. If you could double check I haven't messed anything up I'd appreciate it!

@cpu cpu mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants