Skip to content

Disable botan dependency and tests on macOS #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

djc
Copy link
Member

@djc djc commented Nov 18, 2020

Building Botan on macOS apparently is not supported upstream:

"Currently, systems other than Windows and POSIX (such as VMS,
MacOS 9, OS/390, OS/400, …) are not supported by the build system,
primarily due to lack of access."

https://botan.randombit.net/handbook/building.html

Building Botan on macOS apparently is not supported upstream:

"Currently, systems other than Windows and POSIX (such as VMS,
MacOS 9, OS/390, OS/400, …) are not supported by the build system,
primarily due to lack of access."

https://botan.randombit.net/handbook/building.html
Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@est31 est31 merged commit ef63ca7 into rustls:master Nov 19, 2020
est31 added a commit that referenced this pull request Mar 4, 2021
PR #42 / ef63ca7 wasn't needed.
The botan author has ensured that their library works on macos
just fine.

Closes #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants