Reimplement library on top of rustls::KernelConnection#61
Closed
swlynch99 wants to merge 8 commits intorustls:mainfrom
Closed
Reimplement library on top of rustls::KernelConnection#61swlynch99 wants to merge 8 commits intorustls:mainfrom
rustls::KernelConnection#61swlynch99 wants to merge 8 commits intorustls:mainfrom
Conversation
This type contains all the tricky logic WRT to actually implementing the TLS protocol on top of kTLS. Everything else can be a (mostly) straightforward wrapper around it.
Contributor
Author
|
I still have a bunch of work to do on this PR (as CI will indicate) but I do plan to keep filling it in. |
Collaborator
As far as I'm concerned, yes — I'm not actively developing it and this seems like a worthwhile direction. |
Contributor
Author
|
Closing this in favor of #62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR isn't quite complete yet but as I keep pushing forward with it I find that I'm basically rewriting the whole crate here. I would like to get some feedback on whether this direction is worth continuing in this direction before I finish + polish up the remaining parts of the PR.
TL;DR: Is it OK if I basically end up rewriting the whole crate here?
Here's how the code looks now:
KTlsStreamImpltype. This is generic so that it can be shared between the different connection types but generics needed to do this are rather messy so it is hidden from the public API.KTlsClientStream,KTlsServerStream, andKTlsStreamwhich are on top ofKTlsStreamImpland work how you would expect them to.KTlsConnectorandKTlsAcceptor(similarly to how it works intokio-rustls)I've also made some smaller changes:
io::Error)Here's things that can no longer be supported and/or are no longer necessary:
KTlsStreamfrom atokio_rustls::TlsStream.TlsStreamis built on top ofClientConnection/ServerConnectionbut creating aKernelConnectionrequires an unbuffered connection.CorkStreamis no longer necessary along with a few other methods.TODOs:
Fixes #59