Allow overriding server name #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikailBag
force-pushed
the
server-name-override
branch
2 times, most recently
from
76ced6d to
da6e451
Compare
Signed-off-by: Mikail Bagishov <bagishov.mikail@yandex.ru>
MikailBag
force-pushed
the
server-name-override
branch
from
da6e451 to
d934db6
Compare
Contributor
Author
|
CI failure seems unrelated |
MikailBag
commented
Sep 18, 2022
djc
reviewed
Sep 19, 2022
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Thanks, this broadly makes sense. Some improvements suggested below.
djc
approved these changes
Oct 20, 2022
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original case: kube-rs/kube#991
If I understand correctly, hyper-rustls (and other TLS connectors) is the only place to implement this feature since it is responsible for calling this function.