fix: add symlinks for sidecar binaries in Nix flake#49
Merged
Conversation
The desktop app's sidecar lookup fails when running via nix flake, falling back to PATH lookup. This adds: 1. Symlinks without target triple suffix (e.g., rustfava-server) 2. rustfava -> rustfava-server symlink for backwards compatibility Also updates main.rs fallback to use rustfava-server directly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
robcohen
force-pushed
the
fix/flake-sidecar-symlinks
branch
from
aac6d67 to
22f8aad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustfava->rustfava-serversymlink for backwards compatibility with v0.1.2rustfava-serverdirectly (for future releases)Problem
nix run github:rustledger/rustfava#desktopfailed because:rustfavawhich didn't existTest
nix run .#desktopNow launches the app (though there's a separate internal server error to investigate).
🤖 Generated with Claude Code