feat(transfer): add get and put compatibility aliases - #314
Merged
Conversation
cxymds
marked this pull request as ready for review
July 24, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rc getandrc putcompatibility commandscpplanner and execution path/from being misclassified as remote aliasesWhy
RustFS CLI has the canonical copy implementation, but the mc-compatible
getandputentry points from rustfs/backlog#1382 were still missing. Thin direction-aware wrappers provide compatibility without duplicating transfer behavior.User impact
rc getaccepts exactly one remote source and a local target.rc putaccepts one or more local sources and a remote target. Retry, progress, errors, fidelity options, and output remain identical torc cpbecause all commands use the same implementation.BREAKING change assessment
BREAKING: no. These are new compatibility entry points and do not change the existing
rc cpinterface or execution behavior. The marker is included because this PR updates protected command reference documentation.Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacegit diff --checkCloses rustfs/backlog#1485
Refs rustfs/backlog#1382