This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Fix build on macos m1 #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ca32be6)
|
Looks good. Just to confirm, this only occurs if you target macos on a non mac machine? |
philpax
added a commit
that referenced
this pull request
Nov 12, 2023
This code doesn't feel right. The original order pre-#426 should work - why would mcpu=native not work in that case? I think this is something that will need revisiting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a build using Jenkins agent I got an error
-mcpu=nativeis not available for clang