Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Better GPU Documentation #385

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Better GPU Documentation #385

merged 2 commits into from
Jul 23, 2023

Conversation

LLukas22
Copy link
Contributor

@LLukas22 LLukas22 commented Jul 23, 2023

Moved GPU Documentation to acceleration-support.md and added documentation on how to enable gpu support and which model architectures are supported.

Rendered Version

@LLukas22 LLukas22 requested a review from danforbes July 23, 2023 15:19
Copy link
Collaborator

@philpax philpax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor grammar nits but otherwise merge once fixed

README.md Outdated Show resolved Hide resolved
doc/acceleration-support.md Outdated Show resolved Hide resolved

## Utilizing GPU Support

To activate GPU support, set the `use_gpu` attribute of the `ModelParameters` to `true`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"To activate GPU support (assuming that you have enabled one of the features above),"

doc/acceleration-support.md Outdated Show resolved Hide resolved
doc/acceleration-support.md Outdated Show resolved Hide resolved
@LLukas22
Copy link
Contributor Author

@philpax could you apply your proposed changes and have @danforbes take a final look?

@philpax philpax merged commit 0b435ab into rustformers:main Jul 23, 2023
@LLukas22 LLukas22 deleted the chore/gpu-documentation branch July 26, 2023 08:55
@hhamud hhamud mentioned this pull request Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants