Fix clippy lints

.github/workflows/main.yml

@@ -21,7 +21,30 @@ jobs:
       - uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-targets --all-features
+          args: --all-targets --all-features -- -D warnings
+
+  clippy-windows:
+    name: Clippy-Windows
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: Install Erlang/Elixir
+        run: choco install elixir
+      - name: Extend PATH
+        run: echo "::add-path::C:\\ProgramData\\chocolatey\\lib\\Elixir\\bin"
+      - name: Build API
+        working-directory: rustler_sys
+        run: |
+            cargo build
+      - uses: actions-rs/toolchain@v1
+        with:
+            toolchain: nightly
+            components: clippy
+            override: true
+      - uses: actions-rs/clippy-check@v1
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          args: --all-targets --all-features -- -D warnings
 
   format:
     name: Format

rustler/build.rs

@@ -33,11 +33,14 @@ fn activate_versions(version: &str) {
     let index = NIF_VERSION
         .iter()
         .position(|&v| v == version)
-        .expect(&format!(
-            "Erlang version {} not handled, please file a a bug report.",
-            version
-        ));
-
+        .unwrap_or_else(|| {
+            panic!(
+                "Erlang version {} not handled, please file a a bug report.",
+                version
+            )
+        });
+
+    #[allow(clippy::needless_range_loop)]
     for i in 0..=index {
         println!(
             "cargo:rustc-cfg=nif_version_{}",

rustler/src/lib.rs

@@ -1,4 +1,5 @@
 #![allow(non_camel_case_types)]
+#![allow(clippy::missing_safety_doc)]
 
 //! [Github](https://github.com/rusterlium/rustler)
 //! [Example](https://github.com/hansihe/Rustler_Example)

rustler_codegen/src/init.rs

@@ -27,7 +27,7 @@ impl Parse for InitMacroInput {
 fn parse_expr_assigns(input: ParseStream) -> Vec<syn::ExprAssign> {
     let mut vec = Vec::new();
 
-    while let Ok(_) = <Token![,]>::parse(input) {
+    while <Token![,]>::parse(input).is_ok() {
         match syn::ExprAssign::parse(input) {
             Ok(expr) => vec.push(expr),
             Err(err) => panic!("{} (i.e. `load = load`)", err),
@@ -41,7 +41,7 @@ fn extract_option(args: Vec<syn::ExprAssign>, name: &str) -> TokenStream {
         if let syn::Expr::Path(syn::ExprPath { path, .. }) = &*left {
             if let Some(ident) = path.get_ident() {
                 if *ident == name {
-                    let value = *right.clone();
+                    let value = *right;
                     return quote!(Some(#value));
                 }
             }

rustler_codegen/src/nif.rs

@@ -15,7 +15,7 @@ pub fn transcoder_decorator(args: syn::AttributeArgs, fun: syn::ItemFn) -> Token
     let arity = arity(inputs.clone());
     let decoded_terms = extract_inputs(inputs.clone());
     let argument_names = create_function_params(inputs.clone());
-    let erl_func_name = extract_attr_value(args.clone(), "name")
+    let erl_func_name = extract_attr_value(args, "name")
         .map(|ref n| syn::Ident::new(n, Span::call_site()))
         .unwrap_or_else(|| name.clone());
 

rustler_sys/build.rs

@@ -11,7 +11,7 @@ const SNIPPET_NAME: &str = "nif_api.snippet";
 
 fn try_gen_api(dst: &Path, pointer_size: usize) -> bool {
     // use environment escript if available
-    let escript = env::var("ESCRIPT").unwrap_or("escript".to_string());
+    let escript = env::var("ESCRIPT").unwrap_or_else(|_| "escript".to_string());
 
     if let Ok(res) = Command::new(escript)
         .arg("gen_api.erl")

rustler_sys/src/initmacro.rs

@@ -278,7 +278,6 @@ mod initmacro_namespace_tests {
     // use rustler_sys_api::*;
     use crate::rustler_sys_api;
 
-    use std;
     use std::ffi::{CStr, CString};
     use std::ptr;
     use std::slice;
@@ -355,7 +354,7 @@ mod initmacro_namespace_tests {
 #[cfg(test)]
 mod initmacro_tests {
     use crate::rustler_sys_api::*;
-    use std;
+
     use std::ffi::{CStr, CString};
     use std::ptr;
     use std::slice;

rustler_sys/src/rustler_sys_api.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::missing_safety_doc)]
+
 #[cfg(windows)]
 use unreachable::UncheckedOptionExt; // unchecked unwrap used in generated Windows code