Fix clippy::needless_range_loop, op_ref,assertions_on_constants, and add one test #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgarzik
requested changes
Oct 1, 2024
| Ok(()) | ||
| } | ||
| Some(ref mut f) => f.write_all(buf), | ||
| None => Ok(()), |
Contributor
There was a problem hiding this comment.
What is the reason for the assert!()? Usually these are intentional and should not be removed.
Contributor
Author
There was a problem hiding this comment.
The assertion assert!(false) will never be executed.
Contributor
There was a problem hiding this comment.
My gut instinct is there is an edge case we are missing. Nonetheless, going to merge this PR and hope edge case, if any, is caught later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.