Skip to content

Conversation

@fox0
Copy link
Contributor

@fox0 fox0 commented Sep 24, 2024

No description provided.

run: cargo test --release --verbose
- name: Run fmt check
run: cargo fmt --all -- --check
# - name: Run clippy check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. A PR should "do what it says, and no more"

  2. Never add commented-out code or instructions. Any code not run is code never tested, and will become fragile and break.

  3. Delete the commented out part of this PR, and it is ok.

@jgarzik jgarzik merged commit a43c530 into rustcoreutils:main Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants