Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fmt check in CI #251

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add fmt check in CI #251

merged 2 commits into from
Sep 24, 2024

Conversation

fox0
Copy link
Contributor

@fox0 fox0 commented Sep 24, 2024

No description provided.

run: cargo test --release --verbose
- name: Run fmt check
run: cargo fmt --all -- --check
# - name: Run clippy check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. A PR should "do what it says, and no more"

  2. Never add commented-out code or instructions. Any code not run is code never tested, and will become fragile and break.

  3. Delete the commented out part of this PR, and it is ok.

@jgarzik jgarzik merged commit a43c530 into rustcoreutils:main Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants