-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Replace variant ImeRequest::Disable with fn disable_ime #4426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Would you prefer to merge changes piecemeal (just this commit) or shall I push more IME changes into this PR? The plan is roughly outlined here. |
|
I think I'll also look myself into it one more time and probably push some of the changes myself. |
|
As you like. I already made further changes (not pushed yet): move |
|
If you split them into commits, it's fine with me. I can tune based on that. |
|
Pushed. My further plans are less concrete:
|
|
I think that |
changelogmodule if knowledge of this change could be valuable to usersThis is the first part of #4412. It could be merged as-is or in concert with other changes.
Summary
Replace
ImeRequest::Disablewith fndisable_ime.Motivation
It was documented that
ImeRequest::Disablecannot fail, yet it returned aResult. This revision removes the API ambiguity.