Add myself as iOS co-maintainer #2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
DS - uikit
Member
Author
|
Concretely, I'd really like to get #2427 merged at some point, and it sounds like you won't really be able to review/test it, so I think it makes sense to have a discussion here of whether you would be comfortable with me merging such changes to iOS? |
francesca64
approved these changes
Aug 31, 2022
Member
francesca64
left a comment
francesca64
left a comment
There was a problem hiding this comment.
I totally trust you! Feel free to merge anything you'd like, and thanks a ton for stepping up.
Member
Author
|
Wonderful, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @francesca64, you noted in #2428 (comment) that you no longer have access to iOS devices (also sorry to hear you're unemployed if you're affected by that in other ways!).
I'm quite proficient in Objective-C at this point, and have access to an iOS device I can test on, and while that is of course very far from "knowing" UIKit, I think it would make sense for me to take on co-responsibility of the iOS platform. I'll probably be limiting myself to stuff relating to Objective-C to begin with, e.g. I wouldn't really feel comfortable tackling #2144.