Split platform::unix into platform::x11 and platform::wayland
#2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
DS - x11
madsmtm
force-pushed
the
split-platform-unix
branch
from
8e80a29 to
80b88ce
Compare
madsmtm
force-pushed
the
split-platform-unix
branch
from
80b88ce to
4342209
Compare
Member
|
I agree with this decision. Wayland and X11 are very different, so it makes sense to keep them in their own separate modules. |
madsmtm
force-pushed
the
split-platform-unix
branch
from
4342209 to
0682f7e
Compare
madsmtm
commented
Aug 12, 2022
3 tasks
kchibisov
requested changes
Sep 1, 2022
kchibisov
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were basically no overlap between the platform-specific extensions in these, so it made little sense to keep them in the same file!
Will gladly rename the functions as well, e.g.
wayland_set_csd_theme -> set_csd_theme?Blocked-ish on #2420