Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Fix inner_size() and inner_position() of minimized window #2176

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Windows: Fix inner_size() and inner_position() of minimized window #2176

wants to merge 4 commits into from

Conversation

kazzix14
Copy link

@kazzix14 kazzix14 commented Feb 1, 2022

This PR fixes #2015.
I found that minimized_window.inner_position() also returns invalid value which is Ok(PhysicalPosition { x: -32000, y: -32000 }), so I fixed it too.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@kazzix14 kazzix14 changed the title Fix inner_size and inner_position of minimized window Windows: Fix inner_size() and inner_position() of minimized window Feb 1, 2022
@maroider maroider added DS - windows C - waiting on maintainer A maintainer must review this code labels Feb 1, 2022
parasyte
parasyte reviewed Apr 7, 2022
View reviewed changes
Copy link

@parasyte parasyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this patch, I should be able to remove several zero-checks from about 30 different projects. 🤞

src/platform_impl/windows/window.rs Outdated Show resolved Hide resolved
@madsmtm madsmtm added the B - bug Dang, that shouldn't have happened label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasyte parasyte parasyte left review comments

@filnet filnet filnet left review comments

@maroider maroider Awaiting requested review from maroider

@msiglreith msiglreith Awaiting requested review from msiglreith

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
B - bug Dang, that shouldn't have happened C - waiting on maintainer A maintainer must review this code DS - windows
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: inner_size() reports 0x0 size when window is minimized
5 participants
@kazzix14 @parasyte @filnet @madsmtm @maroider