Skip to content

Handle EINTR on X11 #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kchibisov merged 1 commit into from
Nov 20, 2021
Merged

Handle EINTR on X11 #2031

kchibisov merged 1 commit into from
Nov 20, 2021

Conversation

@mahkoh
Copy link
Contributor

@mahkoh mahkoh commented Oct 4, 2021

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@maroider maroider added DS - x11 Affects the X11 backend, or generally free Unix platforms C - waiting on maintainer A maintainer must review this code labels Oct 4, 2021
Ralith
Ralith reviewed Oct 15, 2021
View reviewed changes
@mahkoh mahkoh mentioned this pull request Oct 21, 2021
Closed
20 tasks
kchibisov
kchibisov requested changes Oct 30, 2021
View reviewed changes
Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry and update the branch? After that should be good to go.

@kchibisov kchibisov mentioned this pull request Oct 31, 2021
Merged
9 tasks
@mahkoh
X11: Don't panic on EINTR
74dda3f 
EINTR will happen if you attach a debugger to the program.
@mahkoh mahkoh force-pushed the graceful-interrupt branch from 6e6b25b to 74dda3f Compare November 19, 2021 22:19
@mahkoh
Copy link
Contributor Author

mahkoh commented Nov 19, 2021

Done

@kchibisov kchibisov merged commit e9d5b20 into rust-windowing:master Nov 20, 2021
@tarkah tarkah mentioned this pull request Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kchibisov kchibisov kchibisov requested changes

+2 more reviewers

@Ralith Ralith Ralith left review comments

@tailhook tailhook tailhook approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C - waiting on maintainer A maintainer must review this code DS - x11 Affects the X11 backend, or generally free Unix platforms

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mahkoh @Ralith @tailhook @kchibisov @maroider