Skip to content

Adds Android winit<->ndk_glue version match table #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
francesca64 merged 5 commits into from
Aug 11, 2021
Merged

Adds Android winit<->ndk_glue version match table #1993

francesca64 merged 5 commits into from
Aug 11, 2021

Conversation

@tachyon-ops
Copy link
Contributor

@tachyon-ops tachyon-ops commented Aug 11, 2021

  • README.md updated to show android ndk_glue/winit version matching.

@tachyon-ops tachyon-ops mentioned this pull request Aug 11, 2021
Closed
@maroider maroider added DS - android Affects the Android backend C - waiting on maintainer A maintainer must review this code S - docs Awareness, docs, examples, etc. labels Aug 11, 2021
@ArturKovacs
Copy link
Contributor

ArturKovacs commented Aug 11, 2021

Uuu I like this. Although I'm not familiar with Android develeopment. @msiglreith what do you think?

msiglreith
msiglreith reviewed Aug 11, 2021
View reviewed changes
@tachyon-ops tachyon-ops force-pushed the improvement/android_readme branch from ac3ee71 to 989020a Compare August 11, 2021 17:36
msiglreith
msiglreith reviewed Aug 11, 2021
View reviewed changes
msiglreith
msiglreith approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msiglreith
Copy link
Member

msiglreith commented Aug 11, 2021

ah right, CI does t run on README only changes

@maroider
Copy link
Member

maroider commented Aug 11, 2021

I guess it usually receives changes alongside changes to .rs files.

Save us, @francesca64, you're our only hope!

@maroider maroider added C - waiting on author Waiting for a response or another PR and removed C - waiting on maintainer A maintainer must review this code labels Aug 11, 2021
@francesca64 francesca64 merged commit 1972eb9 into rust-windowing:master Aug 11, 2021
@MarijnS95
Copy link
Member

MarijnS95 commented Aug 11, 2021

Should we possibly also re-export ndk_glue somewhere from winit, so that it is always available under the same version?

@maroider maroider removed the C - waiting on author Waiting for a response or another PR label Aug 11, 2021
@msiglreith
Copy link
Member

msiglreith commented Aug 12, 2021

Should we possibly also re-export ndk_glue somewhere from winit, so that it is always available under the same version?

agree, reexporting it with the next release would make sense - I will create an issue for it to keep track

@msiglreith msiglreith mentioned this pull request Aug 12, 2021
Closed
20 tasks
@msiglreith msiglreith mentioned this pull request Nov 2, 2021
Merged
8 tasks
@MarijnS95 MarijnS95 mentioned this pull request Dec 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msiglreith msiglreith msiglreith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DS - android Affects the Android backend S - docs Awareness, docs, examples, etc.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tachyon-ops @ArturKovacs @msiglreith @maroider @MarijnS95 @francesca64