add composition event support for Mac #1669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
* WIP: add composition event suppor prototype This change requires x11-dl crate Also, I should send actual string in IME * send actual preedit string * run cargo fmt * update cargo.toml * remove warning * address comments in PR * follow web spec After the discussion on the PR, I decided to follow the Web specification for the composition events. I added a few states to filter out unnecessary events. * remove println * fix cursor pos calc * Re-run CI Co-authored-by: Murarth <murarth@gmail.com>
kchibisov
force-pushed
the
composition-event
branch
from
d3bcee3 to
84f26b0
Compare
Member
|
I'll take a look on it once we figure out renaming and preferred event structure on #1622, if you have any concerns or questions you can chime in. |
kaiwk
force-pushed
the
composition-event
branch
from
698f925 to
3f2e088
Compare
Co-authored-by: Kirill Chibisov <contact@kchibisov.com>
Member
|
We've updated the composition branch, so if you can update your PR based on that it'll be nice. |
kaiwk
force-pushed
the
composition-event
branch
from
3f2e088 to
964c269
Compare
Closes servo/core-foundation-rs#405, seems we don't need InputMethodKit bindings.
kaiwk
force-pushed
the
composition-event
branch
from
964c269 to
1484cc7
Compare
Member
|
Note, you'd need to send IME::Enable at some point, though, given that both X11 and macOS doesn't have such information I may end up removing this even entirely. |
Contributor
Author
|
Not sure why CI failed. |
8 tasks
8 tasks
kchibisov
force-pushed
the
composition-event
branch
from
65cf069 to
12dfeda
Compare
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to userssee: #1497