Skip to content

Fix macOS NSView release call #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kchibisov merged 2 commits into from
Sep 3, 2022
Merged

Fix macOS NSView release call #1453

kchibisov merged 2 commits into from
Sep 3, 2022

Conversation

@madsmtm
Copy link
Member

@madsmtm madsmtm commented Sep 3, 2022

Looked through message sends and stuff after #1435, looks good otherwise.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

kchibisov
kchibisov requested changes Sep 3, 2022
View reviewed changes
@kchibisov kchibisov merged commit 193304d into master Sep 3, 2022
@madsmtm madsmtm deleted the fix-macos-release branch September 3, 2022 16:27
@madsmtm madsmtm mentioned this pull request Sep 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kchibisov kchibisov kchibisov approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@madsmtm @kchibisov