prepare for publish vm-superio(-ser) #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each crate in the vm-superio workspace has a link to the license files, so they will be included when packaging the crate to be published. Signed-off-by: Laura Loghin <lauralg@amazon.com>
crates/vm-superio/CHANGELOG.md
Outdated
Comment on lines
13
to
14
| - The constructors of the `Rtc` device are all creating an instance from a | ||
| state now ([#65](https://github.com/rust-vmm/vm-superio/pull/65)). |
Member
There was a problem hiding this comment.
This is not a public facing change of the interface, I think we should exclude as customers not wanting to use from_state shouldn't need to change anything.
Added separate CHANGELOG for each crate and updated the vm-superio version. Signed-off-by: Laura Loghin <lauralg@amazon.com>
andreeaflorescu
approved these changes
Oct 25, 2021
alexandruag
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After publishing vm-superio 0.5.0, this comment will have to be addressed: #65 (comment). After that, we can release vm-superio-ser 0.1.0.