Build and install additional packages for rutabaga_gfx #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorindabassey
requested review from
andreeaflorescu,
lauralt,
stefano-garzarella,
stsquad,
roypat and
ShadowCurse
as code owners
stsquad
previously approved these changes
Aug 8, 2024
|
IIUC this contains also the patch of #109 , please can you rebase on main? I'd like to merge that patch with the right PR. |
The vhost-device-gpu crate linked here rust-vmm/vhost-device#668 contains rutabaga_gfx and needs some packages and virglrenderer greater that 1.0.0 which is not available in the used ubuntu image, so install the neccessary packages that are available in ubuntu's repositories and for unavailable packages build and install it manually. Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
dorindabassey
force-pushed
the
container
branch
from
92de9a5
to
d163bac
Compare
ok done. Thanks! |
stefano-garzarella
approved these changes
Aug 8, 2024
stsquad
approved these changes
Aug 9, 2024
dorindabassey
pushed a commit
to dorindabassey/rust-vmm-ci
that referenced
this pull request
Aug 9, 2024
This version includes vhost-device-gpu dependencies which is required for vhost-device-gpu crate more info about the crate can be found here: rust-vmm/vhost-device#668 link to the PR that adds these dependencies where the tag is generated can be found here: rust-vmm/rust-vmm-container#110 Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
4 tasks
ShadowCurse
pushed a commit
to rust-vmm/rust-vmm-ci
that referenced
this pull request
Aug 9, 2024
This version includes vhost-device-gpu dependencies which is required for vhost-device-gpu crate more info about the crate can be found here: rust-vmm/vhost-device#668 link to the PR that adds these dependencies where the tag is generated can be found here: rust-vmm/rust-vmm-container#110 Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The vhost-device-gpu crate linked here
rust-vmm/vhost-device#668
contains rutabaga_gfx and needs some packages and
virglrenderer greater that 1.0.0 which is not available
in the used ubuntu image, so install the neccessary
packages that are available in ubuntu's repositories and
for unavailable packages build and install it manually.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.