get_gpa_access_state: avoid returning dangling reference #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, VmFd::get_gpa_access_state returned a dangling reference (in the form of a raw pointer) to a vector that was allocated and freed during the function call. This commit modifies it to instead return the vector directly, since no other information is required by its only consumer (VmFd::get_dirty_log). Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
syntactically
requested review from
russell-islam,
liuw,
NunoDasNeves and
jinankjain
as code owners
jinankjain
approved these changes
Sep 2, 2024
|
@NunoDasNeves I will leave it to you to tag 0.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Users of mshv-ioctls-0.2.x can experience heap corruption when using dirty page tracking, and need this patch to avoid this.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.