Skip to content

build(deps): update vm-memory requirement from 0.12.2 to 0.13.0 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2023
Merged

build(deps): update vm-memory requirement from 0.12.2 to 0.13.0 #162

merged 2 commits into from
Oct 13, 2023

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 25, 2023 •
edited
Loading

Updates the requirements on vm-memory to permit the latest version.

Changelog

Sourced from vm-memory's changelog.

[v0.13.0]

Added

  • [#247](rust-vmm/vm-memory#247) Add ReadVolatile and WriteVolatile traits which are equivalents of Read/Write with volatile access semantics.

Changed

  • [#247](rust-vmm/vm-memory#247) Deprecate Bytes::{read_from, read_exact_from, write_to, write_all_to}. Instead use ReadVolatile/WriteVolatile, which do not incur the performance penalty of copying to hypervisor memory due to Read/Write being incompatible with volatile semantics (see also #217).

[v0.12.2]

Fixed

  • [#251](rust-vmm/vm-memory#251): Inserted checks that verify that the value returned by VolatileMemory::get_slice is of the correct length.

Deprecated

  • [#244](rust-vmm/vm-memory#241) Deprecate volatile memory's as_ptr() interfaces. The new interfaces to be used instead are: ptr_guard() and ptr_guard_mut().

[v0.12.1]

Fixed

[v0.12.0]

Added

[v0.11.0]

Added

Fixed

  • [#217](rust-vmm/vm-memory#217) Fix vm-memory internally taking rust-style slices to guest memory in ways that could potentially cause

... (truncated)

Commits
  • a6bcb43 chore: Prepare release 0.13.0
  • 51a6c74 Add CHANGELOG entry about ReadVolatile/WriteVolatile
  • 20135ce Adjust coverage
  • 7a911a4 Add read_volatile_from/write_volatile_to to GuestMemory
  • 9c3e6aa test: Add tests for VolatileRead/Write
  • 0173112 feat: Introduce Read/WriteVolatile traits
  • See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from alxiord as a code owner September 25, 2023 20:38
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 25, 2023
@dependabot dependabot bot requested a review from sameo as a code owner September 25, 2023 20:38
@dependabot dependabot bot added the rust Pull requests that update Rust code label Sep 25, 2023
@dependabot dependabot bot force-pushed the dependabot/cargo/vm-memory-0.13.0 branch from b67217a to 098da65 Compare October 9, 2023 20:50
@JonathanWoollett-Light JonathanWoollett-Light force-pushed the dependabot/cargo/vm-memory-0.13.0 branch from 316569a to 098da65 Compare October 10, 2023 09:02
@roypat
Copy link
Member

roypat commented Oct 10, 2023

This is blocked on rust-vmm/vm-memory#256

@roypat roypat force-pushed the dependabot/cargo/vm-memory-0.13.0 branch 5 times, most recently from b5aa9ba to b21357f Compare October 13, 2023 08:23
@stefano-garzarella
Copy link
Member

stefano-garzarella commented Oct 13, 2023

@roypat for bisectability would it be better to merge the first 2 commits together?
IIUC the first one fails to compile right?

@roypat
Copy link
Member

roypat commented Oct 13, 2023

@roypat for bisectability would it be better to merge the first 2 commits together? IIUC the first one fails to compile right?

Mh, I think usually we try to keep the dependabot-created commits untouched, and add the fixes in additional commits onto the dependabot branch.

@stefano-garzarella
Copy link
Member

stefano-garzarella commented Oct 13, 2023

@roypat for bisectability would it be better to merge the first 2 commits together? IIUC the first one fails to compile right?

Mh, I think usually we try to keep the dependabot-created commits untouched, and add the fixes in additional commits onto the dependabot branch.

Okay, sorry I'm not codeowner of this crate, so I didn't know about this policy. I personally prefer to try to have every commit buildable, but it’s up to you ;-)

@rbradford
Copy link
Collaborator

rbradford commented Oct 13, 2023 •
edited
Loading

@roypat for bisectability would it be better to merge the first 2 commits together? IIUC the first one fails to compile right?

Mh, I think usually we try to keep the dependabot-created commits untouched, and add the fixes in additional commits onto the dependabot branch.

I don't think that sounds like a very good idea from a bisectability perspective. I don't think the dependabot's feelings will be hurt if you take it's commit and git commit --amend --reset-author and turn it into a generic dependency bump commit.

@roypat roypat force-pushed the dependabot/cargo/vm-memory-0.13.0 branch from b21357f to 3a13d47 Compare October 13, 2023 10:10
@roypat
Copy link
Member

roypat commented Oct 13, 2023

@roypat for bisectability would it be better to merge the first 2 commits together? IIUC the first one fails to compile right?

Mh, I think usually we try to keep the dependabot-created commits untouched, and add the fixes in additional commits onto the dependabot branch.

I don't think that sounds like a very good idea from a bisectability perspective. I don't think the dependabot's feelings will be hurt if you take it's commit and git commit --amend --reset-author and turn it into a generic dependency bump commit.

Alright, if we don't care about preserving the dependabot commits then I don't see any problems either :) I've squashed the first two commits.
To be fair, its not like it didn't compile, there were simply new compiler warnings that I don't think would cause any problems with bisection.

roypat and others added 2 commits October 13, 2023 11:12
@roypat
build: update vm-memory requirement from 0.12.2 to 0.13.0
312a777 
Updates the requirements on [vm-memory](https://github.com/rust-vmm/vm-memory) to permit the latest version.
- [Release notes](https://github.com/rust-vmm/vm-memory/releases)
- [Changelog](https://github.com/rust-vmm/vm-memory/blob/main/CHANGELOG.md)
- [Commits](rust-vmm/vm-memory@v0.12.2...v0.13.0)

---
updated-dependencies:
- dependency-name: vm-memory
  dependency-type: direct:production
...

In addition to the dependabot changes, this commit updates usages of
deprecated functions.

With vm-memory 0.13.0, we introduced versions of the Read and Write
traits for operations on guest memory (`VolatileRead` and
`VolatileWrite`). These replace various `Read` and `Write` based APIs
that had suboptional performance due to requiring to first copy all data
from guest memory to hypervisor memory to ensure soundness. See also
rust-vmm/vm-memory#217.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Co-authored-by: dependabot[bot] <support@github.com>
@roypat
chore: Update CHANGELOG.md
e86ba8a 
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat roypat force-pushed the dependabot/cargo/vm-memory-0.13.0 branch from 3a13d47 to e86ba8a Compare October 13, 2023 10:12
@epilys
Copy link
Member

epilys commented Oct 13, 2023

+1 on squashing dependabot's commits. You can mention it was originally an automatic dependabot PR in the commit description if you like.

@rbradford
Copy link
Collaborator

rbradford commented Oct 13, 2023

Alright, if we don't care about preserving the dependabot commits then I don't see any problems either :) I've squashed the first two commits.
To be fair, its not like it didn't compile, there were simply new compiler warnings that I don't think would cause any problems with bisection.

Ah, my mistake - I didn't realise it was "just a warning". I can see the merits of both ways when it comes to a warning but for build errors I do think it's better for the tree to be bisectable.

@roypat roypat merged commit 7cf6c84 into main Oct 13, 2023
@dependabot dependabot bot deleted the dependabot/cargo/vm-memory-0.13.0 branch October 13, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbradford rbradford rbradford approved these changes

@JonathanWoollett-Light JonathanWoollett-Light JonathanWoollett-Light approved these changes

@alxiord alxiord Awaiting requested review from alxiord

@sameo sameo Awaiting requested review from sameo sameo is a code owner

@roypat roypat Awaiting requested review from roypat roypat is a code owner

@andreitraistaru andreitraistaru Awaiting requested review from andreitraistaru andreitraistaru is a code owner

+2 more reviewers

@Ablu Ablu Ablu approved these changes

@epilys epilys epilys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@roypat @stefano-garzarella @rbradford @epilys @Ablu @JonathanWoollett-Light