Store and write namespaces #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| continue; | ||
| } | ||
|
|
||
| let key = try!(str::from_utf8(name)).to_string(); |
There was a problem hiding this comment.
This could maybe be try!(String::from_utf8(name))?
There was a problem hiding this comment.
We're not able to use String::from_utf8 here since name is a &[u8] and String::from_utf8 requires a Vec<u8>.
There was a problem hiding this comment.
Ah, in that case, I suppose try!(String::from_utf8(name.to_owned())) is not much of an improvement. Carry on.
There was a problem hiding this comment.
Yeah, I decided to go with str::from_ut8 just so the bytes are verified to be valid UTF-8 before duplicating them in to a Vec/String.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespaces are stored in
channel.namespacesso that custom namespaces can be resolved and written.