FIX resource leak #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add misssing use - Add needed :? for object not implementing fmt - Add a few no_run & compile_fail when needed
- Ultimatly this log will remain but with a configurable logger
As refered to on this page: https://doc.rust-lang.org/std/process/struct.Child.html you need to wait() each child process to make sure the ressources are properly freed. This was actually causing the program to crash when calling a command containing a pipe in a loop.
|
Thanks for the patch. yes, I am also planning to implement the logger interface whenever I have more free time. |
|
Hello Tao, thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Detail about resource leak (6cf978b):
As referred to on this page: https://doc.rust-lang.org/std/process/struct.Child.html
you need to wait() each child process to make sure the resources are properly freed.
This was actually causing the program to crash when calling a command containing a pipe
in a loop.