Revert #981 with a proper support for CXXSTDLIB#1029
Merged
zaidoon1 merged 1 commit intorust-rocksdb:masterfrom Aug 13, 2025
Merged
Revert #981 with a proper support for CXXSTDLIB#1029zaidoon1 merged 1 commit intorust-rocksdb:masterfrom
CXXSTDLIB#1029zaidoon1 merged 1 commit intorust-rocksdb:masterfrom
Conversation
aleksuss
reviewed
Aug 13, 2025
stanislav-tkach
approved these changes
Aug 13, 2025
zaidoon1
approved these changes
Aug 13, 2025
pcholakov
pushed a commit
to pcholakov/rust-rocksdb
that referenced
this pull request
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default
cccrate will link C++ standard library with respect toCXXSTDLIBenv so there is no need to specify it manually when building RocksDB. However, when we use a manually compiled version, we still need to link stdc++. Otherwise it is not possible to use this library withROCKSDB_STATIC=1env without creating a build script or custom rustflags.This PR reverts #981 and just adds a branch where we use
CXXSTDLIBenv.P.S. It also makes sure that
<cstdint>is included on linuxFixes #1014