Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cfg(panic = unwind) instead of a check for wasm32 to see if unwinding is supported #1341

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Oct 2, 2023

This allows the test to run on a future wasm target with exception support as well as running the test suite with panic=abort on non-wasm targets.

…ding is supported

This allows the test to run on a future wasm target with exception support as
well as running the test suite with panic=abort on non-wasm targets.
@bjorn3
Copy link
Contributor Author

bjorn3 commented Oct 2, 2023

@bjorn3
Copy link
Contributor Author

bjorn3 commented Oct 2, 2023

Looks like this is not yet available for the MSRV (1.56). It is only available starting from 1.60. It is a test, not something that would get compiled when using it as dependency, so maybe that is fine?

@dhardy
Copy link
Member

dhardy commented Oct 4, 2023

Honestly, upgrading to 1.60 should be fine.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Oct 4, 2023

Pushed a commit to update the MSRV.

@newpavlov
Copy link
Member

Regarding the remaining CI failure, you can replace mips-unknown-linux-gnu with powerpc-unknown-linux-gnu.

@dhardy dhardy merged commit e42c385 into rust-random:master Oct 11, 2023
12 checks passed
@bjorn3 bjorn3 deleted the panic_abort_test branch October 11, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants